fix(metricsai): rename security_compliance_thumbs_down column to plural - #31
Merged
Merged
Conversation
Align the compliance thumbs-down metric key with its security counterpart (security_thumbs_downs) and the updated Google Sheet header. Updates the emitted metric, the expected-columns test, and the README column list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the metric column
security_compliance_thumbs_down→security_compliance_thumbs_downseverywhere it appears, fixing an inconsistency where the compliance family used the singular form while the security family used the plural (security_thumbs_downs). The Google Sheet header has already been updated to the plural form for consistency.Changes
src/metricsai/modules/security.py— the emitted metric keytests/test_security.py— the expected-columns setREADME.md— the documentedsecurity_compliance_*column listThe internal
Comment.thumbs_downdataclass field and(thumbs_up, thumbs_down)reaction naming are unchanged — they are not spreadsheet columns.Testing
uv run pytest tests/test_security.py— 5 passed.🤖 Generated with Claude Code